Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add clangd support #9772

Merged
merged 3 commits into from
Dec 12, 2024
Merged

tools: add clangd support #9772

merged 3 commits into from
Dec 12, 2024
+12 −3

Conversation

supperthomas
Copy link
Member

@supperthomas supperthomas commented Dec 11, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

workspace中添加clangd的支持，实现精确跳转

你的解决方案是什么 (what is your solution)

发现生成了compile_command.json 文件之后，workspace中添加支持。
只要在bsp中的SConstruct添加下面代码即可，然后执行scons --target=vsc 打开workspace文件即可跳转

env.Tool('compilation_db')
env.CompilationDatabase()
# make a building
DoBuilding(TARGET, objs)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/nrf5x/nrf5340
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the tools label Dec 11, 2024
@mysterywolf
Copy link
Member

1733959694001
能不能调用python库函数自动更处理\和/，否则手动处理windows和unix的路径分隔符会很痛苦

mysterywolf
mysterywolf approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先approve了 看看后续可否改进一下

@supperthomas
Copy link
Member Author

supperthomas commented Dec 12, 2024 •
edited
Loading 

                normalized_path = path['path'].replace('\\', os.path.sep)
                segments = [p for p in normalized_path.split(os.path.sep) if p != '..']
                path['name'] = 'rtthread/' + '/'.join(segments)

这个已经将windows的替换了，前面可能还有些其他情况。暂时不care，后面可能会再调整一下，后面再优化，小步快走。后面优化的时候，会考虑这块。

@supperthomas supperthomas merged commit b81d73e into master Dec 12, 2024
46 checks passed
@supperthomas supperthomas deleted the support_clangd branch December 12, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterywolf mysterywolf mysterywolf approved these changes

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supperthomas @mysterywolf